Sanitize filename: Replace ": " with " -" but replace ":" with "-"

[johankj]

Downloading videos from YouTube containing ":" will make odd sanitized filenames.
Currently ":" is replaced with " -" which makes perfect sense in the case of "Some Title: Subtitle" which will then be transformed to "Some Title - Subtitle".
But in cases where the title contains a timestamp like "New World Record at 0:12:34" it gets transformed to "New World Record at 0 -12 -34" instead of the slightly better "New World Record at 0-12-34".

It could be solved by e.g. looping over the string and looking at the next char, instead of mapping each char:

for i in range(len(s)):
    char = s[i]
    if char == '?' or ord(char) < 32 or ord(char) == 127:
        char = ''
    elif char == '"':
        char = '' if restricted else '\''
    elif char == ':' and s[i+1] == ' ':
        char = '_-' if restricted else ' -'
    elif char == ':':
        char = '-' if restricted else '-'
    elif char in '\\/|*<>':
        char = '_'
    if restricted and (char in '!&\'()[]{}$;`^,#' or char.isspace()):
        char = '_'
    if restricted and ord(char) > 127:
        char = '_'
    s = s[:i] + char + s[i+1:]

[phihag]

Thank you for the report. I believe this issue to be fixed in youtube-dl 2015.01.11 and newer. See our FAQ if you need help updating.