Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit ec82d85 breaks --write-thumbnail. #4812

Closed
Hajitorus opened this issue Jan 29, 2015 · 2 comments
Closed

Commit ec82d85 breaks --write-thumbnail. #4812

Hajitorus opened this issue Jan 29, 2015 · 2 comments
Labels
bug

Comments

@Hajitorus
Copy link

@Hajitorus Hajitorus commented Jan 29, 2015

If I check out commit cfb56d1, --write-thumbnail will correctly record thumbnails, as in:

% ~git/youtube-dl/youtube-dl --write-thumbnail --download-archive=/dev/null KAZrNrcgrRc
[youtube] KAZrNrcgrRc: Downloading webpage
[youtube] KAZrNrcgrRc: Extracting video information
[youtube] KAZrNrcgrRc: Downloading DASH manifest
[youtube] KAZrNrcgrRc: Downloading thumbnail ...
[youtube] KAZrNrcgrRc: Writing thumbnail to: Handmade Hero Day 053 - Environment Elements as Entities-KAZrNrcgrRc.jpg
[download] Handmade Hero Day 053 - Environment Elements as Entities-KAZrNrcgrRc.mp4 has already been downloaded
[ffmpeg] Not converting video file Handmade Hero Day 053 - Environment Elements as Entities-KAZrNrcgrRc.mp4 - already is in target format mp4

However, reverting to any commit more recent than that, (like HEAD) will not write thumbnails:

% ~git/youtube-dl/youtube-dl --write-thumbnail --download-archive=/dev/null KAZrNrcgrRc
[youtube] KAZrNrcgrRc: Downloading webpage
[youtube] KAZrNrcgrRc: Extracting video information
[youtube] KAZrNrcgrRc: Downloading DASH manifest
[download] Handmade Hero Day 053 - Environment Elements as Entities-KAZrNrcgrRc.mp4 has already been downloaded
[ffmpeg] Not converting video file Handmade Hero Day 053 - Environment Elements as Entities-KAZrNrcgrRc.mp4 - already is in target format mp4

This appears to be directly related to the changes made in ec82d85.

@jaimeMF jaimeMF added the bug label Jan 29, 2015
@jaimeMF jaimeMF closed this in a7a14d9 Jan 29, 2015
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Jan 29, 2015

Thansk for the report, it will work again in the next version (or if you want, you can just use the HEAD version).

@phihag
Copy link
Contributor

@phihag phihag commented Jan 30, 2015

I believe this issue to be fixed in youtube-dl version 2015.01.30.1 and newer. See our FAQ if you need help updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.