Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash is incorrect #493

Closed
dumpweed opened this issue Oct 26, 2012 · 6 comments
Closed

Hash is incorrect #493

dumpweed opened this issue Oct 26, 2012 · 6 comments

Comments

@dumpweed
Copy link

@dumpweed dumpweed commented Oct 26, 2012

MD5, SHA1, and SHA256 are incorrect:
http://rg3.github.com/youtube-dl/download.html

@phihag
Copy link
Contributor

@phihag phihag commented Oct 26, 2012

Umm, are you certain you have the correct file? I've tried it from three different machines, but I always get the right values:

$ wget -q https://github.com/rg3/youtube-dl/raw/2012.10.09/youtube-dl -O-|sha256sum
f83e0dbe6a13d6cc7c07755c55511f1dbb8a4b99215b277d0a0f1477d87df37d  -

How are you downloading youtube-dl (with what browser/OS/etc.), where from, and how are you checking the checksums?

@dumpweed
Copy link
Author

@dumpweed dumpweed commented Oct 26, 2012

Thanks for the quick reply!
Ubuntu 10.04 command line:
At Pacific Time 5:30 AM, I used the following commnads to download but the checksums are different!
$wget https://github.com/rg3/youtube-dl/raw/2012.10.09/youtube-dl
............
$sha1sum youtube-dl
46c58f78f99aca2697d2582f214bb0bd2c50c319c2625def81decd5489571f80 youtube-dl

Now I repeat above commands and the checksums are correct.

I still have the copy from 5:30, the diff command shows they are indeed different:
$diff tmp/youtube-dl edx/youtube-dl
Binary files edx/youtube-dl and tmp/youtube-dl differ

Do you want the file from 5:30? If yes, how do I upload the file?

@phihag
Copy link
Contributor

@phihag phihag commented Oct 26, 2012

Yes, I would be very much interested in the differing file. Can you tell us your ISP or at least country?

Can you mail it to phihag@phihag.de ? Alternatively, you can upload it at dropbox (requires registration) or so.

Closing for now, but we may want to implement some kind of checksum detection upon automatic updating and/or execution.

@phihag phihag closed this Oct 26, 2012
@phihag
Copy link
Contributor

@phihag phihag commented Oct 29, 2012

Sorry, I haven't gotten anything so far. Did you send the mail? You can also just create a repository here at github and directly upload the file into it. Thanks!

@dumpweed
Copy link
Author

@dumpweed dumpweed commented Oct 29, 2012

I did email you the file, also you can get it from here:
https://github.com/dumpweed/tmp/blob/master/youtube-dl

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Oct 29, 2012

Here is the diff https://gist.github.com/3974635
They are completely different versions :O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.