Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Download playlists doesn't work when a newline character is in the title #5161
Comments
|
Works perfectly for me. playlist regex already allows dot to match any character. |
|
Here is the output. Looks like I could use an update. In hindsight, that may be related.
|
|
You are using an outdated version of youtube-dl. Refer to our FAQ if you have trouble updating. |
If there is a new line in a playlist H1 tag, youtube-dl is currently unable to parse out the playlist title. An example of such a playlist is here:
https://www.youtube.com/playlist?list=PLIamkchgCKVuSMFn1m8Yj2d67TyGtQxxE
This can be fixed by allowing the . in the regular expression to accept new lines by using the re.S flag. I did this in my own copy by changing line 362 of common.py to have
flags=re.S
by default instead of
flags=0
I haven't found any negative results from this, but I am not familiar enough with the code to say that there aren't any.
At either rate, thanks for all your hard work, this application is great.