Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI tests exceed 50 minute #5289

Closed
yan12125 opened this issue Mar 26, 2015 · 6 comments
Closed

Travis CI tests exceed 50 minute #5289

yan12125 opened this issue Mar 26, 2015 · 6 comments

Comments

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Mar 26, 2015

References:
[1] https://travis-ci.org/rg3/youtube-dl/builds/55855866
[2] http://docs.travis-ci.com/user/build-configuration/#Job-Timeouts

Travis CI has a hard limit 50 minutes for tests. Lots of recent builds failed because of that. As a result, I can't see the log of failed tests on Travis CI. A possible solution is to run tests in parallel. At least tests for different sites does not depends on each other. Any ideas?

@hlintala
Copy link
Contributor

@hlintala hlintala commented Jun 11, 2015

Another possible solution is to split travis build jobs. Also, if log is longer than 10000 lines, produced output log contains only first 10000 lines. This splitting would also solve that problem.

@yan12125
Copy link
Collaborator Author

@yan12125 yan12125 commented Jun 25, 2015

I've identified 3 problematic sites. They cause timeouts from my location.

In #6081 I commented out these tests. If someone can confirm any of these sites are not online anymore, please remove the extractor.

@hlintala It's also a good idea, while for now I think commenting out problematic sites is sufficient.

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Jun 25, 2015

If we run multiple tests in parallel we'll need to tweak the --process-timeout option for nosetests, I think that the default value is too small for a lot of the tests.

I haven't looked into the travis tests for a while, maybe it would be worth to limit it to the tests in make offlinetest and a few extractors like YouTube, Vimeo and Dailymotion, we could even go crazy and limit the tests to the extractors changed in the commit.

@yan12125
Copy link
Collaborator Author

@yan12125 yan12125 commented Jun 25, 2015

Personally I prefer to keep all tests. I think codes that are rarely used should be tested, too.

@d4t4king
Copy link

@d4t4king d4t4king commented Sep 11, 2015

Is there any documentation stating this limitation, and/or the reasoning for this limitation? A "fast" build for my project would be around 90 minutes. Given the virtualization overhead, etc., I'd expect it to be slightly longer. Will Travis-CI simply not work for me?

@yan12125
Copy link
Collaborator Author

@yan12125 yan12125 commented Sep 12, 2015

This page says the limit is 50 minutes. However, seems builds longer than 50 minutes are allowed (for example this build ) since switching to the new infrastructure in f3a65d9, so I'm closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.