Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for gfycat #5394

Closed
woodenphone opened this issue Apr 10, 2015 · 6 comments
Closed

Add official support for gfycat #5394

woodenphone opened this issue Apr 10, 2015 · 6 comments

Comments

@woodenphone
Copy link

@woodenphone woodenphone commented Apr 10, 2015

While gfycat.com works at the moment, it is not listed in the supported sites.
Can it be officially maintained as a supported site, with detection of the highest quality version if that is possible?
Example video link:
http://gfycat.com/VainRichCub

@mandb
Copy link

@mandb mandb commented Apr 15, 2015

does anybody have documentation on how to build an extractor? Can possibly do a PR.

@mandb
Copy link

@mandb mandb commented Apr 15, 2015

added, PR #5439

You can pull mp4, webm or gif format (default is mp4 if gif not specified in url or with -f), extra details (duration, size, views, etc) added.

http://gfycat.com/RequiredUnkemptBuzzard
[Gfycat] RequiredUnkemptBuzzard: Downloading webpage
{
    "duration": 6,
    "formats": [
        {
            "acodec": "none",
            "bytesize": "749951",
            "ext": "webm",
            "format_id": "webm",
            "fps": 29,
            "height": 338,
            "http_headers": {
                "User-Agent": "youtube-dl (like wget)"
            },
            "id": "RequiredUnkemptBuzzard",
            "preference": 0,
            "url": "http://zippy.gfycat.com/RequiredUnkemptBuzzard.webm",
            "vbr": 122.06233723958333,
            "width": 600
        },
        {
            "acodec": "none",
            "bytesize": "5935649",
            "ext": "gif",
            "format_id": "gif",
            "fps": 29,
            "height": 338,
            "http_headers": {
                "User-Agent": "youtube-dl (like wget)"
            },
            "id": "RequiredUnkemptBuzzard",
            "preference": 1,
            "url": "http://giant.gfycat.com/RequiredUnkemptBuzzard.gif",
            "vbr": 966.0887044270834,
            "width": 600
        },
        {
            "acodec": "none",
            "bytesize": "1740123",
            "ext": "mp4",
            "format_id": "mp4",
            "fps": 29,
            "height": 338,
            "http_headers": {
                "User-Agent": "youtube-dl (like wget)"
            },
            "id": "RequiredUnkemptBuzzard",
            "preference": 2,
            "url": "http://fat.gfycat.com/RequiredUnkemptBuzzard.mp4",
            "vbr": 283.22314453125,
            "width": 600
        }
    ],
    "id": "RequiredUnkemptBuzzard",
    "title": "Headshot!",
    "view_count": 448486
}
@julianrichen
Copy link
Contributor

@julianrichen julianrichen commented Apr 15, 2015

I was working on this as well, guess you beat me to it! Regarding your pull it might be better to use the built in json api they have as it will cut down on the code.:

http://gfycat.com/cajax/get/<video_id>

The url http://gfycat.com/cajax/get/RequiredUnkemptBuzzard returns:

{
  "gfyItem": {
    "gfyId": "requiredunkemptbuzzard",
    "gfyName": "RequiredUnkemptBuzzard",
    "gfyNumber": "607648367",
    "userName": "anonymous",
    "width": 600,
    "height": 338,
    "frameRate": 29,
    "numFrames": 180,
    "mp4Url": "http://fat.gfycat.com/RequiredUnkemptBuzzard.mp4",
    "webmUrl": "http://zippy.gfycat.com/RequiredUnkemptBuzzard.webm",
    "gifUrl": "http://giant.gfycat.com/RequiredUnkemptBuzzard.gif",
    "gifSize": 5935649,
    "mp4Size": 1740123,
    "webmSize": 749951,
    "createDate": "1422584031",
    "views": 492324,
    "title": "Headshot!",
    "extraLemmas": null,
    "md5": "5dd3ed3ff36e37839cb11fb2faeff3a5",
    "tags": null,
    "nsfw": "0",
    "likes": "6",
    "dislikes": 0,
    "published": 1,
    "description": null,
    "copyrightClaimaint": null,
    "sar": "1",
    "url": "https://i.4cdn.org/wsg/1422071452954.webm",
    "source": "1",
    "dynamo": null,
    "subreddit": "all",
    "redditId": "32ol2t",
    "redditIdText": "a_skillful_headshot",
    "uploadGifName": null
  }
}

Might still make a pr if the api json version is prefered, not finished coding it.

@mandb
Copy link

@mandb mandb commented Apr 15, 2015

if there's json readily available probably best to use that, you can recycle the url match regex and extension preference.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 17, 2015

Gfycat will be supported in the next version. Thanks for the report.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 26, 2015

Support for gfycat has been added in youtube-dl 2015.04.26. See our FAQ if you have problems updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.