Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

best[height=] downloads Video-Only DASH when height is only available in DASH... #5554

Closed
ghost opened this issue Apr 29, 2015 · 7 comments
Closed
Assignees

Comments

@ghost
Copy link

@ghost ghost commented Apr 29, 2015

As requested, here is a verbose output of a youtube 'best[height=]' option that is downloading video-only DASH. As stated before, I was able to get around it by doing '<=' instead of '='. This seems to be a script-glitch from asking it to pull a resolution that is only available in DASH.


youtube-dl -v -f best[height=480] https://www.youtube.com/watch?v=_PNBF_LGrfM
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'-f', u'best[height=480]', u'https://www.youtube.com/watch?v=_PNBF_LGrfM']
[debug] Encodings: locale US-ASCII, fs utf-8, out US-ASCII, pref US-ASCII
[debug] youtube-dl version 2015.04.28
[debug] Python version 2.7.8 - Darwin-8.11.0-Power_Macintosh-powerpc-32bit
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] _PNBF_LGrfM: Downloading webpage
[youtube] _PNBF_LGrfM: Extracting video information
[youtube] _PNBF_LGrfM: Downloading DASH manifest
[debug] Invoking downloader on 'https://r6---sn-qxo7sn7k.googlevideo.com/videoplayback?id=fcf34117f2c6adf3&itag=135&source=youtube&requiressl=yes&mm=31&ms=au&mv=m&pl=16&ratebypass=yes&mime=video/mp4&gir=yes&clen=27477814&lmt=1430256318389239&dur=339.714&mt=1430327681&key=dg_yt0&fexp=900720,907263,934954,938028,9406690,9407588,9407877,9408007,9408705,9408710,9408787,9409205,9409230,9412839,9413011,9413149,947233,948124,952612,952637,957201&sver=3&upn=tPFdYxEOYkM&signature=6F146691843968AD129BD05B140922A1ABD65D96.97DE5911E48E99520EE5208297519740AF696615&ip=97.115.165.13&ipbits=0&expire=1430349373&sparams=ip,ipbits,expire,id,itag,source,requiressl,mm,ms,mv,pl,ratebypass,mime,gir,clen,lmt,dur'
[download] Destination: Classic Game Room - QUICK STEP review for Atari 2600-_PNBF_LGrfM.mp4
[download] 100% of 26.20MiB in 00:34

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 29, 2015

There are no exactly-480-height non-DASH videos by that link. What would you expect to happen in this case? Throwing an error that requested format is not available?

@ghost
Copy link
Author

@ghost ghost commented Apr 29, 2015

I know. jaimeMF asked me to post this as a new issue. They said that best[height] should not pass DASH and want to track it down.

@rg3
Copy link
Collaborator

@rg3 rg3 commented Apr 29, 2015

Cross-referencing issue #5550

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 29, 2015

@jaimeMF what do you think should we do? Throwing format not available error may break use flow of audio only extractors like soundcloud. Implementing best similarly to worst will still end up in fallback to audio/video-only formats when filter is not satisfied for audiovideo formats.

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Apr 29, 2015

I thought that best would only select non-DASH formats, but it doesn't (and it have never worked like that). Maybe we should do like with worst, but without falling back to DASH formats. For audio only extractors it should work as now, I have to look if it can be easily implemented.

It's just my opinion, maybe you disagree.

@jaimeMF jaimeMF self-assigned this Apr 29, 2015
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Apr 29, 2015

I have opened a PR with the proposed change: #5554.

@jaimeMF jaimeMF closed this in 8dd5418 Apr 30, 2015
dstftw added a commit that referenced this issue Apr 30, 2015
Make 'best' format only match non-DASH formats (closes #5554)
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 30, 2015

This will be fixed in the next version. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.