Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl wrongly claims extended attributes are not supported when setxattr() returns ENOSPC #5589

Closed
fstirlitz opened this issue May 3, 2015 · 1 comment

Comments

@fstirlitz
Copy link
Contributor

@fstirlitz fstirlitz commented May 3, 2015

On an ext4 filesystem:

$ > x; setfattr -n user.test -v 123 x; getfattr -d x; rm x
# file: x
user.test="123"

$ youtube-dl -v --xattrs 3TR_YuDFIFI
…
[metadata] Writing metadata to file's xattrs
ERROR: This filesystem doesn't support extended attributes. (You may have to enable them in your /etc/fstab)
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/youtube_dl/postprocessor/xattrpp.py", line 120, in run
    write_xattr(filename, xattrname, byte_value)
  File "/usr/lib/python3.4/site-packages/youtube_dl/postprocessor/xattrpp.py", line 54, in write_xattr
    return xattr.setxattr(path, key, value)
OSError: [Errno 28] No space left on device

And I wish youtube-dl treated this as a warning anyway, or provided a way to slim down the metadata stored. The only xattr I actually care for is user.xdg.referrer.url (the original URL); the rest (usually) already fits inside regular media tags.

@yan12125 yan12125 closed this in 86c7fdb May 14, 2015
@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented May 14, 2015

Thanks for the report. Now a warning instead of an error is issued in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.