Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--restrict-filenames sometimes partly ignored #566

Closed
goodevilgenius opened this issue Nov 28, 2012 · 2 comments
Closed

--restrict-filenames sometimes partly ignored #566

goodevilgenius opened this issue Nov 28, 2012 · 2 comments

Comments

@goodevilgenius
Copy link

@goodevilgenius goodevilgenius commented Nov 28, 2012

youtube-dl --restrict-filenames -f 18 --get-filename -o "%(uploader)s/%(title)s-%(id)s.%(ext)s" 'http://www.youtube.com/watch?v=ixq2E01ZI20&feature=youtube_gdata'

I would expect the output to be kesha/Keha_-_Die_Young_Remix_feat._Juicy_J_Wiz_Khalifa_Becky_G-ixq2E01ZI20.mp4 but instead I got kesha/Ke$ha_-_Die_Young_Remix_(feat._Juicy_J,_Wiz_Khalifa_Becky_G)-ixq2E01ZI20.mp4

Maybe the $ is throwing it off, or you're not filtering out [$,()]?

@phihag phihag closed this in 627dcff Nov 28, 2012
@phihag
Copy link
Contributor

@phihag phihag commented Nov 28, 2012

We did indeed not filter these characters (technically, that was correct, as the documentation didn't mention them). Sorry, --restrict-filenames is relatively new. I performed an exhaustive search and checked that all allowed characters are not in the default COMP_WORDBREAKS now.

Thanks for reporting! This has been fixed in the current git. We'll release a new version soon. It may take some more time than usual because the Windows build may need to be adapted the recent Python 3 compatibility changes.

@goodevilgenius
Copy link
Author

@goodevilgenius goodevilgenius commented Nov 28, 2012

Awesome! I grabbed the most recent version from git, and that fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.