Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When -t is enabled, some underscores are being lost from video code #571

Closed
ekevoo opened this issue Dec 3, 2012 · 3 comments
Closed

When -t is enabled, some underscores are being lost from video code #571

ekevoo opened this issue Dec 3, 2012 · 3 comments

Comments

@ekevoo
Copy link

@ekevoo ekevoo commented Dec 3, 2012

Steps:
Download video in the examples below with -t

Current behaviour:
For some videos, an underscore character is being dropped from the video code.

Expected:
Videos downloaded with -t should match the pattern TITLE-CODE.EXTENSION exactly.

Examples:

http://www.youtube.com/watch?v=_BD_eEpuzXw
saves wrongly as Pendulum - Propane Nightmares [HD - 320kbps]-BD_eEpuzXw.video

http://www.youtube.com/watch?v=_n_cd26wFpw
saves wrongly as Tekkit 69 - Tetris Machine-n_cd26wFpw.mp4

http://www.youtube.com/watch?v=N0Y__7-UOdI
saves wrongly as MLP - FiM BGM - Float Parade-N0Y_7-UOdI.mp4

@phihag
Copy link
Contributor

@phihag phihag commented Dec 3, 2012

More precisely, this suggestion implies that we shouldn't change underlines or dashes in IDs.

@phihag phihag closed this in 796173d Dec 3, 2012
@phihag
Copy link
Contributor

@phihag phihag commented Dec 3, 2012

Solved in git, will be in the next release. Thanks for reporting!

@ekevoo
Copy link
Author

@ekevoo ekevoo commented Dec 3, 2012

Wow that was fast! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.