Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--download-archive compatibility issue with --embed-thumbnail when no thumbnail exists #5797

Closed
gak1234 opened this issue May 23, 2015 · 1 comment

Comments

@gak1234
Copy link

@gak1234 gak1234 commented May 23, 2015

I found an interesting condition just now. When downloading a SoundCloud track that does not have a thumbnail, the track ID will not be written to the archive.txt even though the track was downloaded successfully.

Verbose output:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', '--embed-thumbnail', '--download-archive', 'archive.txt', '-w', '-i', 'https://soundcloud.com/user4428730/test-upload']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2015.05.20
[debug] Python version 3.4.3 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-70875-g3c5c687
[debug] Proxy map: {}
ERROR: Thumbnail was not found. Nothing to do.
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 1531, in post_process
files_to_delete, info = pp.run(info)
File "C:\Python34\lib\site-packages\youtube_dl\postprocessor\embedthumbnail.py", line 34, in run
raise EmbedThumbnailPPError('Thumbnail was not found. Nothing to do.')
youtube_dl.postprocessor.embedthumbnail.EmbedThumbnailPPError: Thumbnail was not found. Nothing to do.

ERROR: local variable 'files_to_delete' referenced before assignment
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 660, in extract_info
return self.process_ie_result(ie_result, download, extra_info)
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 706, in process_ie_result
return self.process_video_result(ie_result, download=download)
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 1157, in process_video_result
self.process_info(new_info)
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 1469, in process_info
self.post_process(filename, info_dict)
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 1534, in post_process
if files_to_delete and not self.params.get('keepvideo', False):
UnboundLocalError: local variable 'files_to_delete' referenced before assignment

@gak1234 gak1234 changed the title --download-archive compatibility issue with --embed-thumbnail --download-archive compatibility issue with --embed-thumbnail when no thumbnail exists May 23, 2015
@dstftw dstftw closed this in 71646e4 May 23, 2015
@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 23, 2015

Will be fixed in the next version. Thanks for the report.
By the way this issue is not anyhow related to --download-archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.