Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmetics] Updating youtube-dl.exe #5810

Open
Reino17 opened this issue May 25, 2015 · 2 comments
Open

[Cosmetics] Updating youtube-dl.exe #5810

Reino17 opened this issue May 25, 2015 · 2 comments
Labels

Comments

@Reino17
Copy link

@Reino17 Reino17 commented May 25, 2015

While updating youtube-dl the temporary youtube-dl-updater.bat performs this task:

@echo off
echo Waiting for file handle to be closed ...
ping 127.0.0.1 -n 5 -w 1000 > NUL
move /Y "D:\Storage\Media\Binaries\youtube-dl.exe.new" "D:\Storage\Media\Binaries\youtube-dl.exe" > NUL
echo Updated youtube-dl to version 2015.01.10.2.
start /b "" cmd /c del "%~f0"&exit /b"

Now for some reason the move-command (or something else?) causes a new commandprompt to appear, followed by the final echo + a new linefeed:

D:\Storage\Media\Binaries>youtube-dl.exe -U
Updating to version 2015.05.20 ...
Waiting for file handle to be closed ...

D:\Storage\Media\Binaries>Updated youtube-dl to version 2015.05.20.

D:\Storage\Media\Binaries>

You'd always have to press ENTER for the commandprompt to appear again.

When I save the temporary bat-file and run it localy on a dummy youtube-dl.exe.new and youtube-dl.exe.new it performs as expected:

D:\Storage\Media\Binaries>youtube-dl-updater.bat
Waiting for file handle to be closed ...
Updated youtube-dl to version 2015.01.10.2.

D:\Storage\Media\Binaries>

The final echo is displayed and the commandprompt appears again.
This behaviour is a but confusing, especially in batchscripts where I use youtube-dl.exe. Is this normal?

@Reino17
Copy link
Author

@Reino17 Reino17 commented Jun 25, 2015

@yan12125 wrote in #5994:

If you will, try it on the next update.

Still the same:

D:\Storage\Media\Binaries>youtube-dl.exe -U
Updating to version 2015.06.25 ...
Waiting for file handle to be closed ...

D:\Storage\Media\Binaries>Updated youtube-dl to version 2015.06.25.
_ (<-- prompt)

Or do I have to wait for yet another update to see any changes? Hasn't this issue been fixed with a commit, like every other issue?

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Jun 25, 2015

@pargitejas's issue is slightly different. He/She is missing the prompt, and I guess he/she needs an extra Enter. Your issue is not solved yet, and I'll try to have a look these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.