Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double quotes are replaced with single quotes in the filename #5959

Closed
krakrock opened this issue Jun 12, 2015 · 1 comment
Closed

double quotes are replaced with single quotes in the filename #5959

krakrock opened this issue Jun 12, 2015 · 1 comment
Labels

Comments

@krakrock
Copy link

@krakrock krakrock commented Jun 12, 2015

The song I'm trying to download has double quotes in the title, yet when I run it through youtube-dl, it outputs it with single quotes.

How it should be:

Jason Derulo - "Talk Dirty" feat. 2 Chainz (Official HD Music Video)

How it outputs as:

Jason Derulo - 'Talk Dirty' feat. 2 Chainz (Official HD Music Video)

Here's my command:

echo shell_exec('youtube-dl -o "/var/www/dler/audio/%(title)s|' . getID($link) . '.%(ext)s" --write-thumbnail --embed-thumbnail -x --audio-format mp3 "' . $link . '"');

What am I doing wrong?

@krakrock krakrock changed the title Outputting single quotes, not double quotes Outputting with single quotes, rather than double quotes Jun 12, 2015
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Jun 12, 2015

We remove them in sanitize_filename, it was changed to remove double quotes in #502. I don't know if keeping them would cause some problem.

@jaimeMF jaimeMF added the request label Jun 12, 2015
@jaimeMF jaimeMF changed the title Outputting with single quotes, rather than double quotes double quotes are replaced with single quotes in the filename Jun 12, 2015
@krakrock krakrock closed this Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.