Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Funny or Die broken? #604
Funny or Die broken? #604
Comments
|
Do not ask me why, but named regex groups break it on my system, too, but not on Travis. diff --git a/youtube_dl/InfoExtractors.py b/youtube_dl/InfoExtractors.py
index e3cf7e1..c403bb1 100755
--- a/youtube_dl/InfoExtractors.py
+++ b/youtube_dl/InfoExtractors.py
@@ -3652,7 +3652,7 @@ class JustinTVIE(InfoExtractor):
return info
class FunnyOrDieIE(InfoExtractor):
- _VALID_URL = r'^(?:https?://)?(?:www\.)?funnyordie\.com/videos/(?P<id>[0-9a-f]+)/.*$'
+ _VALID_URL = r'^(?:https?://)?(?:www\.)?funnyordie\.com/videos/([0-9a-f]+)/.*$'
IE_NAME = u'FunnyOrDie'
def report_extraction(self, video_id):
@@ -3664,7 +3664,7 @@ class FunnyOrDieIE(InfoExtractor):
self._downloader.trouble(u'ERROR: invalid URL: %s' % url)
return
- video_id = mobj.group('id')
+ video_id = mobj.group(1)
self.report_extraction(video_id)
try:
urlh = compat_urllib_request.urlopen(url) |
|
Aww, wait, forget what I've just said. I wan on the wrong git HEAD or something (I need sleep). @Vladinator It is ready only in the git repo, so you will need to clone it and Reopen the issue if you don't find it fixed this way! |
youtube-dl "http://www.funnyordie.com/videos/0732f586d7/heart-shaped-box-literal-video-version"
WARNING: Falling back on generic information extractor.
[generic] heart-shaped-box-literal-video-version: Downloading webpage
[generic] heart-shaped-box-literal-video-version: Extracting information
ERROR: Invalid URL: http://www.funnyordie.com/videos/0732f586d7/heart-shaped-box-literal-video-version