Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_sort_formats return None #6059

Closed
remitamine opened this issue Jun 23, 2015 · 2 comments
Closed

_sort_formats return None #6059

remitamine opened this issue Jun 23, 2015 · 2 comments

Comments

@remitamine
Copy link
Collaborator

@remitamine remitamine commented Jun 23, 2015

i'm trying to create an extractor for google drive and also picasa videos i made a working version but when i use the _sort_formats method the extractor stop working.
this is happen because of _sort_formats return None.
in the code i put here i'm using the python sorted function but i think it's better to use the _sort_formats.
if i find a solution i will return to use _sort_formats and try to fork and do a pull request(i didn't do it before)
Google Drive extractor
Picasa extractor

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jun 23, 2015

_sort_formats is supposed to work inplace, so it returns nothing but modifies formats passed in.

@dstftw dstftw closed this Jun 23, 2015
@remitamine
Copy link
Collaborator Author

@remitamine remitamine commented Jun 23, 2015

👍 thank you it works i didn't notice that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.