Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Return list of videos or call FD.download in playlist IEs #608
Comments
|
We should do neither. Instead, every IE - playlist or not - should return a JSON-serializable object describing its results. The
There should be helper functions for the common case of a one-format video and a playlist of URLs. If the IE encounters an error, it should throw one. We should provide a generic If the IE wants to provide feedback to the user, it should call a function that it gets passed upon construction. We can add a helper function We also need to pass the parameters we currently have to the IE then, and not (only) to the downloader. |
Except the ones in youtube subtypes (user, channels ..) all calls to _downloader.to_screen has been changed. The calls not prefixed with the IE name hasn't been touched.
@phihag I can't make my mind on this. (We can also have a IRC chat if you want).
Here's the problem: ATM at the end of
YoutubePlaylistIEwe call FD.download on the found ids. This is a pretty practical solution. However, I think we should consider returning a list instead.Here's the comparison.
Pro
FD.download:Pro
return list:ytdl -o xxx PL63F0C78739B09958, this is a bug, and it is not easily and elegantly solvable ATM.self._downloaderbut this is a blocking issue.A compromise might be to return two lists, one of info_dicts, one of links to add to the download queue.