Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[dramafever] Support subtitle extraction in .srt format #6207
Comments
|
Generally, you should use |
|
Is ttml supported for conversion? I'm doing it wrong, or it doesn't seem to work for me.
|
|
Yes. Conversion itself takes place after download is finished. However, there is a problem when one wants to download just subtitles. |
|
This is unfortunate. I would still argue though that if srt is available at source, it should be a preferred format over ttml. |
|
IIRC srt would require additional HTTP request, my rationale was to minimize networking for info extraction pass. Moreover, ttml is more markup-rich, so it's always possible to convert ttml to srt without information loss, but not vice versa. |
|
Understood.
If you compare http://www.dramafever.com/st/subtitle/4709_1_en.xml against http://www.dramafever.com/st/sub/ohmyghostess_01_clean_JS.srt For other sources, ttml is possibly more preferred, but in DramaFever's case, I do not see the value. |
|
I'm talking about info extraction pass (e.g. |
|
@ping do any of http://api.drama9.com/#get--api-4-episode-info- or http://api.drama9.com/#stream-hls-stream work for you? |
The DramaFever extractor currently only extract subtitles in .ttml format. But DramaFever actually provides subtitles in .srt format but the path to which is only found in the
episode/seriesendpoint (afaik).Example: http://www.dramafever.com/api/4/episode/series/?cs=DA59dtVXYLxajktV&series_id=4709&page_size=1
.srt is a more widely supported format in media players compared to .ttml in my opinion. Can the extractor pull srt subtitles instead, or support the option to choose srt over ttml?