Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using an external downloader, self._make_cmd is considered as a list, not a str #6228

Closed
arter97 opened this issue Jul 14, 2015 · 2 comments
Closed

Comments

@arter97
Copy link

@arter97 arter97 commented Jul 14, 2015

On Python 2.7.2 ported over Android, using an external downloader results in an error.
http://pastebin.com/iwUJ4cHm

Seems like _make_cmd function does not return the cmd as a str.
Using a simple workaround like "return str(cmd)" or "return str(cmd).encode()" still does not work
http://pastebin.com/wxWiYV2V

Please take a look and suggest me a fix.
Thanks :)

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jul 14, 2015

self._make_cmd is expected to be a list. ''.join(cmd) will do what you want.

@dstftw dstftw closed this Jul 14, 2015
@arter97
Copy link
Author

@arter97 arter97 commented Jul 14, 2015

I'm a little Python noob, so excuse me.
The message "TypeError: execv() arg 2 must contain only strings" says it did not get a str on subprocess.Popen.
If self._make_cmd is expected to be a list, where am I supposed to touch and fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.