Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tuning fix for #6151 #6245

Closed
Asadullah-Ahmad opened this issue Jul 15, 2015 · 1 comment
Closed

Fine tuning fix for #6151 #6245

Asadullah-Ahmad opened this issue Jul 15, 2015 · 1 comment

Comments

@Asadullah-Ahmad
Copy link

@Asadullah-Ahmad Asadullah-Ahmad commented Jul 15, 2015

Can some contributor please look at a742c00 and suggest why _search_regex is having issues with that string, so it can be cleaned up for a possible merge/pull.

I came up with that search string by trial and error and can't shake that warning off. If I don't pass fatal=False flag, it raises RegexNotFoundError. Otherwise, it extracts the video_url successfully while still warning that it didn't execute search properly. I tried substituting .{30} with the exact string, but that didn't make a difference.

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Jul 16, 2015

I guess that not all formats are available for each video so some of the regex won't be found. You should probably use default=None instead.

@jaimeMF jaimeMF closed this Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.