when --write-srt fails, youtube-dl exits

[tianon]

On line 464 of InfoExtractors.py, writesubtitles will cause the video downloading to be skipped if downloading the subtitles fails. Shouldn't that be more of a warning than a fatal error? That way, --write-srt could be specified all the time, and only apply if subtitles are actually available and properly downloadable.

[tianon]

As an example, downloading "https://www.youtube.com/watch?v=cgoVvqZ6dfA" with --write-srt fails with:
WARNING: unable to download video subtitles: HTTP Error 400: Bad Request (not sure if it actually has valid, downloadable subtitles, but it does fail and prevent downloading of the video).

[FiloSottile]

We are in progress of completely reviewing our concepts of WARNINGS and ERRORS, but meanwhile the behavior is correct: missing subtitles trigger a WARNING and that stops the execution only if you have not specified -i (--ignore-errors) on the command line.

I think that almost everybody uses (or wants) -i so eventually we will make it default.

Thanks for reporting! Happy downloading.

[tianon]

Ah, that makes perfect sense. Didn't notice -i, or probably wouldn't have even made this ticket. Thanks for clarifying. :)