Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Player.pl (TVN) #6396

Open
marsjaninzmarsa opened this issue Jul 29, 2015 · 2 comments
Open

Add support for Player.pl (TVN) #6396

marsjaninzmarsa opened this issue Jul 29, 2015 · 2 comments

Comments

@marsjaninzmarsa
Copy link

@marsjaninzmarsa marsjaninzmarsa commented Jul 29, 2015

For example this video: http://player.pl/programy-online/kuba-wojewodzki-odcinki,455/odcinek-178,ewelina-lisowska-marcin-spenner-dawid-podsiadlo-i-robert-friedrich,S00E178,13204.html

Downloading is possible, for example via this bookmarklets: http://miniskrypt.blogspot.com/2012/12/tvnplayer-downloader-wersja-20.html

I can try to add it, but I don't promise anything. 😉

Important note: due to text linked above, extracting of video URL may be restricted to Poland, but downloading video should work worldwide. Also - extracted video URL is valid only up to an hour, so I don't know how to pass unit tests (cause I can't just hardcode valid video URL in source)... any ideas?

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Jul 29, 2015

Also - extracted video URL is valid only up to an hour, so I don't know how to pass unit tests (cause I can't just hardcode valid video URL in source)... any ideas?

You don't need to write the video url, read the introduction on how to write an exctractor and some simple extractor like InstagramIE.

@marsjaninzmarsa
Copy link
Author

@marsjaninzmarsa marsjaninzmarsa commented Jul 29, 2015

Or I can provide regex for test, right, thanks!

Also, you have one of the best guides for new contributors I've ever seen, my pull request should be ready today. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.