Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[suggestion] add `text` sub-field in `subtitles` field of JSON #6647
Comments
fqj1994
changed the title
|
This is already implemented. Provide concrete example URLs when subtitles are not extracted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Some sites (kuwo, neteasemusic, qqmusic which youtube-dl supports) doesn't have a url to download subtitles/lyrics but the subtitles/lyrics's content is just part of the HTML page or a field of API response.
Those 3 extractors parsed the subtitles/lyrics of the 3 sites but put it into the
descriptionfield assubtitlesproperty only haveurlfield rather thantextfield or similar things.Adding a new sub-field
text(which can be exclusive withurlsub-field) allow extractors to put parsed subtitles directly into the data if subtitles content is located in a field of the API response rather than another URL.If the owner believes it's OK, I'll do some development and file a PR to update those three extractors.