Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with the re with the cached name new in .js #6691

Closed
CecoMastera opened this issue Aug 27, 2015 · 1 comment
Closed

issue with the re with the cached name new in .js #6691

CecoMastera opened this issue Aug 27, 2015 · 1 comment

Comments

@CecoMastera
Copy link

@CecoMastera CecoMastera commented Aug 27, 2015

Hello,

Here is ex URL:
https://s.ytimg.com/yts/jsbin/html5player-new-bg_BG-vflEnZ74n/html5player-new.js

youtube.py - line 662:

def _extract_signature_function(self, video_id, player_url, example_sig):
    id_m = re.match(
        r'.*?-(?P<id>[a-zA-Z0-9_-]+)(?:/watch_as3|/html5player)?\.(?P<ext>[a-z]+)$',
        player_url)
    if not id_m:
        raise ExtractorError('Cannot identify player %r' % player_url)
    player_type = id_m.group('ext')
    player_id = id_m.group('id')

player_id is always 'new"

Could you please fix it.

Regards,
Tsvetozar Tsolov

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Aug 27, 2015

It's fixed in 4bc8eec. Thanks for the suggestion.

@yan12125 yan12125 closed this Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.