Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Some formats not filterable because of characters not specified in str_operator_rex regex #6858
Comments
|
@aktau I updated the regex pattern to match more codecs. (#8346)
Luckily there was another patch (#8218) which added 3 CSS-like selectors: In your case, this would get best video with avc1/h264 codec: Overwriting avc1 with h264 would make things simpler, but it would require an update for any new format. Keeping the defaults can have its advantages as well, for example, narrower wildcard selection to match a couple of codec sub-variants only: |
|
Awesome, thanks a lot and keep up the great work! |
Regex pattern update to match more codecs (fixes #6858)
Example format:
Say I wanted to prefer the best possible
avcformat, I'm not sure how I could. I tried:But couldn't because the dot (
.) is not part of the regex:Which only seems to allow alphanumeric, dash and underscore for some reason.
What I'm actually looking for is some sort of wildcard:
Or, better yet, some sort of normalization, since as far as I understand it, avc1 is h264. Can anybody tell me why normalization would be undesirable?