Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL should be normalized before trying to match with regex #6882

Open
ghost opened this issue Sep 17, 2015 · 1 comment
Open

URL should be normalized before trying to match with regex #6882

ghost opened this issue Sep 17, 2015 · 1 comment

Comments

@ghost
Copy link

@ghost ghost commented Sep 17, 2015

e.g.
http://tp.srgssr.ch/p/portal?urn=urn%3Asrf%3Aais%3Avideo%3A3fd90c9f-507a-4a79-b6b6-ac55f746b4d4&autoplay=true&legacy=true&width=640&height=360&playerType=

doesn't match, because
urn%3Asrf%3Aais%3Avideo%3A3fd90c9f-507a-4a79-b6b6-ac55f746b4d4
isn't normalized to
urn:srf:ais:video:3fd90c9f-507a-4a79-b6b6-ac55f746b4d4

which would match.

@jsmithyop
Copy link

@jsmithyop jsmithyop commented Sep 17, 2015

That is a valid URL with correctly encoded parameters.
The regular expression can be improved to correctly match that URL.
But, the parameter should be properly extracted from the URL to properly decode it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.