Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl repeats thumbnail embedding if file already exists #6948

Open
nearcatch opened this issue Sep 24, 2015 · 2 comments
Open

youtube-dl repeats thumbnail embedding if file already exists #6948

nearcatch opened this issue Sep 24, 2015 · 2 comments
Labels

Comments

@nearcatch
Copy link

@nearcatch nearcatch commented Sep 24, 2015

[download] Downloading video 87 of 87
[youtube] 8K-RKUbS38o: Downloading webpage
[youtube] 8K-RKUbS38o: Downloading video info webpage
[youtube] 8K-RKUbS38o: Extracting video information
[youtube] 8K-RKUbS38o: Downloading DASH manifest
[youtube] 8K-RKUbS38o: Downloading DASH manifest
[youtube] 8K-RKUbS38o: Downloading thumbnail ...
[youtube] 8K-RKUbS38o: Writing thumbnail to: F:\Random\ASMR\accidentallygraceful\20150917 ASMR _ Softly Spoken Stories  Thumbelina (A Bedtime Story For Relaxation & Sleep)_8K-RKUbS38o.jpg
[download] F:\Random\ASMR\accidentallygraceful\20150917 ASMR _ Softly Spoken Stories  Thumbelina (A Bedtime Story For Relaxation & Sleep)_8K-RKUbS38o.mp4 has already been downloaded and merged
[atomicparsley] Adding thumbnail to "F:\Random\ASMR\accidentallygraceful\20150917 ASMR _ Softly Spoken Stories  Thumbelina (A Bedtime Story For Relaxation & Sleep)_8K-RKUbS38o.mp4"

Using latest version (2015-09-22) as of this post. As you can see from the code, the thumbnail is downloaded before youtube-dl checks the video and sees it has already been downloaded. Then the thumbnail logic embeds the thumbnail file since it is there. This results in a video with duplicate thumbnails.

capture

If the video already exists maybe youtube-dl should assume a thumbnail was already embedded and discard the downloaded one.

@jaimeMF jaimeMF added the request label Sep 25, 2015
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Sep 25, 2015

If the video already exists maybe youtube-dl should assume a thumbnail was already embedded and discard the downloaded one.

It's not that simple, you can quit youtube-dl after the video is downloaded but before the thumbnail is embedded. I guess we should check with ffmpeg if the file already has a thumbnail

@nearcatch
Copy link
Author

@nearcatch nearcatch commented Sep 25, 2015

I am running youtube-dl through a batch file so I don't think I have a way to quit youtube-dl when the file is already downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.