Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

periscope: add support for urls containing username instead of "w" #7503

Closed
Vrihub opened this issue Nov 14, 2015 · 2 comments
Closed

periscope: add support for urls containing username instead of "w" #7503

Vrihub opened this issue Nov 14, 2015 · 2 comments

Comments

@Vrihub
Copy link
Contributor

@Vrihub Vrihub commented Nov 14, 2015

At the moment this kind of url is supported:

https://www.periscope.tv/w/STREAM-ID

But if you browse the periscope website, you sometimes find urls like:

https://www.periscope.tv/USERNAME/STREAM-ID

i.e. with the periscope user's username replacing the "w" character.

This second kind of url works fine in web browsers, but it's not accepted by youtube-dl:

ERROR: Unsupported URL

I'm attaching a patch for youtube_dl/extractor/periscope.py to allow this kind of urls.
The regexp I added requires at least two characters (that's the only requirement about periscope usernames I found on help.periscope.tv), and excludes the same characters forbidden in stream id's.

periscope.py.txt

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Nov 14, 2015

Post an example URL.
We only accept PRs.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Nov 14, 2015

Moreover this patch breaks https://www.periscope.tv/w/STREAM-ID URLs.

@dstftw dstftw closed this in 0c59d02 Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.