Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Thumbnail to Downloaded File #7512

Closed
alloxcwapx0u opened this issue Nov 16, 2015 · 4 comments
Closed

Write Thumbnail to Downloaded File #7512

alloxcwapx0u opened this issue Nov 16, 2015 · 4 comments

Comments

@alloxcwapx0u
Copy link

@alloxcwapx0u alloxcwapx0u commented Nov 16, 2015

Is it possible to download and write the thumbnail to the downloaded file's metadata? I can only figure out how to download the thumbnails but not write them to the downloaded video/audio file. If it's not possible, can you please add the functionality to youtube-dl? Thanks

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Nov 16, 2015

In post-processing options there's --embed-thumbnail. Note that the embedded thumbnail in MP3 files is not supported by Windows Media Player yet. (#5957)

@yan12125 yan12125 closed this Nov 16, 2015
@alloxcwapx0u
Copy link
Author

@alloxcwapx0u alloxcwapx0u commented Nov 16, 2015

Yes! But are there options that I can specify for the thumbnail such as the width and height? What parameters does FFmpeg use to do this? The output seems to be different than the output from this example: https://trac.ffmpeg.org/ticket/2221. That example also seems to be compatible with Windows Media Player.

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Nov 17, 2015

Which version of Windows Media Player are you using?

Also you may need to specify additional parameters to ffmpeg via --postprocessor-args for thumbnail dimensions. youtube-dl can't handle every possible cases.

@alloxcwapx0u
Copy link
Author

@alloxcwapx0u alloxcwapx0u commented Nov 18, 2015

It seems like the main difference from https://trac.ffmpeg.org/ticket/2221 and what's in embedthumbnail.py is that embedthumbnail.py doesn't have the option: id3v2_version 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.