Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Eastern & Aspect issues (differences between 2015.11.27.1 and 2014.05.19) #7781
Comments
|
on topic #5045 it was written: So, why doesnt "--fixup never" work to restore the character output??? |
|
Because these two issues are unrelated. |
|
I was led to believe that the reason why it dumps the characters was because it needs to call ff via the commandline and characters are not able to be passed on. So that was why "fixup-never" should work (IMHO). secondly, why does it not restore the characters in the filename after you have FF modify the file under this "temporary" file name you have given it? also, you just said that 16:9 is used by youtube to display video. |
youtube-dl uses ffmpeg not only for fixup but for lots of other things.
Because no one have implemented this. Files produced by youtube-dl for ESUBitVqhOA with default fixup strategy visually look exactly same as one played in browser (same aspect ratio) regardless on the selected format. Both, YouTube displayed and produced file, have messed up aspect ratio since YouTube suggest and imposes invalid stretch ratio and youtube-dl mimic YouTube's behavior. However in most cases (other videos) stretch suggested by YouTube is correct and should be respected by youtube-dl. This is the rationale why fixup has been introduced. |
|
i guess if i can get the old behavior with the no fixup thing then its not a problem. i had no issues with the old behavour so i didnt see why i needed this. I guess i will have to find another video that YTDL messes up the stretch on so that you can see if there is a problem and if there is a solution (i deleted the one i had, and i download lots). thanks for your time. |
There are TWO differences - bugs - between these two versions of youtubeDL.
The proceedure is the same for both issues, refer to VERBOSE output for the commandline input. Used --no-check-certificate only due to newest version, added to both for completeness. Version 2015.10.18 has the same issue as the latest one.
From what i can see, both issues are linked - it for some reason wants to convert the aspect ratio, and it cannot send eastern characters in the command line so it makes a friendly name.
Issue A. Eastern Characters (chinese) are not rendered correctly. (you need the fonts installed to view)
issue B. Aspect ratio of selected video format stuffed up (i am using media player classic).
old version creates file name called: "張雨生&姚可傑&邰正宵&張啟娜 - 烈火青春-ESUBitVqhOA.mp4"
new version creates file name called: "&&& - -ESUBitVqhOA.mp4"
old version aspect ratio and resolution: 540x360
new version aspect ratio and resolution: 540x360 but forced to be 16:9
old version VERBOSE output:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-i', '--write-sub', '-f', '18/5', '--embed-subs', '
https://www.youtube.com/watch?v=ESUBitVqhOA', '--verbose', '--no-check-certifica
te']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2014.05.19
[debug] Python version 2.7.5 - Windows-XP-5.1.2600-SP3
[debug] Proxy map: {}
[youtube] Setting language
[youtube] ESUBitVqhOA: Downloading webpage
[youtube] ESUBitVqhOA: Downloading video info webpage
[youtube] ESUBitVqhOA: Extracting video information
WARNING: video doesn't have subtitles
[download] Destination: ???&???&???&??? - ????-ESUBitVqhOA.mp4
[download] 100% of 12.97MiB in 00:31
[ffmpeg] There aren't any subtitles to embed
new version VERBOSE output:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-i', u'--write-sub', u'-f', u'18/5', u'--embed-sub
s', u'https://www.youtube.com/watch?v=ESUBitVqhOA', u'--verbose', u'--no-check-c
ertificate']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2015.11.27.1
[debug] Python version 2.7.10 - Windows-XP-5.1.2600-SP3
[debug] exe versions: ffmpeg N-64167-gca35037
[debug] Proxy map: {}
[youtube] ESUBitVqhOA: Downloading webpage
[youtube] ESUBitVqhOA: Downloading video info webpage
[youtube] ESUBitVqhOA: Extracting video information
WARNING: video doesn't have subtitles
[youtube] ESUBitVqhOA: Downloading DASH manifest
[youtube] ESUBitVqhOA: Downloading DASH manifest
[debug] Invoking downloader on u'https://r8---sn-uxanug5-coxz.googlevideo.com/vi
deoplayback?initcwndbps=1127500&id=o-AJRqOJ-SlHU9zY0KehI0I-cZS5Sj22OZkn68n993BTs
C&sparams=dur%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cm
s%2Cmv%2Cpcm2cms%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cupn%2Cexpire&ip=101.1
77.29.106&pcm2cms=yes&requiressl=yes&pl=18&expire=1449493489&sver=3&ratebypass=y
es&lmt=1429764988458446&signature=B582B6808F52EDD2C108327457CD87FBD3D9F409.20B6B
7C527B4AE0432D3B70400D80BA6A527F642&ipbits=0&mime=video%2Fmp4&itag=18&key=yt6&fe
xp=9408710%2C9416126%2C9417683%2C9420452%2C9421410%2C9422596%2C9422618%2C9423459
%2C9423662&ms=au&mt=1449471820&mv=m&dur=260.736&upn=8d_UsvoBT84&source=youtube&m
m=31&mn=sn-uxanug5-coxz'
[download] Destination: &&& - -ESUBitVqhOA.mp4
[download] 100% of 12.97MiB in 00:31
[ffmpeg] Fixing aspect ratio in "&&& - -ESUBitVqhOA.mp4"
[debug] ffmpeg command line: ffmpeg -y -i 'file:&&& - -ESUBitVqhOA.mp4' -c copy
-aspect 1.777778 'file:&&& - -ESUBitVqhOA.temp.mp4'
[ffmpeg] There aren't any subtitles to embed