Install via setup.py fails

[spqr2]

Issue present in 43ff1a3 . bash-completion is absent, but still specified in setup.py, leading to errors at install time:

+ python setup.py install --prefix=/usr --root=/home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64
running install
running build
running build_py
running build_scripts
running install_lib
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/FileDownloader.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/InfoExtractors.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/PostProcessor.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/__init__.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/__main__.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/update.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/utils.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
copying build/lib/youtube_dl/version.py -> /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/FileDownloader.py to FileDownloader.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/InfoExtractors.py to InfoExtractors.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/PostProcessor.py to PostProcessor.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/__init__.py to __init__.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/__main__.py to __main__.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/update.py to update.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/utils.py to utils.pyc
byte-compiling /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/lib/python2.7/site-packages/youtube_dl/version.py to version.pyc
running install_data
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/etc
creating /home/abuild/rpmbuild/BUILDROOT/youtube-dl-20130403-0.x86_64/usr/etc/bash_completion.d
error: can't copy 'youtube-dl.bash-completion': doesn't exist or not a regular file
error: Bad exit status from /var/tmp/rpm-tmp.shtYT6 (%install)

[spqr2]

python setup.py build does not build everything that python setup.py install is to install, which is how this fails. Having to use make instead - well, it's possible (and the issue may be closed) but goes against the idea of setup.py.

[FiloSottile]

As you imagined at the moment building is done via make, and setup.py needed files are shipped pre-built with the release tarballs.

Probably the best approach here would be building youtube-dl.bash-completion, README.txt and youtube-dl.1 with setup.py, and call setup.py from make for those files.

Leaving this issue open to discuss and implement the above.

[jaimeMF]

What about adding the three files to the git repo?
Pros:

• People can have the man page without having to install pandoc
• No more problems when using setyp.py with the source code, youtube-dl.bash-completion is easy to create, but not everyone wants to install pandoc just for having README.txt and the manpages.

Cons:

• They will probably be, at worst, one version outdated, which is not too bad.