Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[comcarcoff] Comedians in Cars Getting Coffee out of date #7941

Closed
ausbin opened this issue Dec 22, 2015 · 0 comments
Closed

[comcarcoff] Comedians in Cars Getting Coffee out of date #7941

ausbin opened this issue Dec 22, 2015 · 0 comments

Comments

@ausbin
Copy link
Contributor

@ausbin ausbin commented Dec 22, 2015

Hi.

Because of a change in where the Comedians in Cars Getting Coffee website puts its JSON payload, the extractor no longer works. Using commit c722407 (HEAD at the moment):

$ ./youtube-dl -v http://comediansincarsgettingcoffee.com/stephen-colbert-cut-up-and-bloody-but-looking-good
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://comediansincarsgettingcoffee.com/stephen-colbert-cut-up-and-bloody-but-looking-good']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.12.21
[debug] Python version 3.5.1 - Linux-4.2.5-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 2.8.4, ffprobe 2.8.4, rtmpdump 2.4
[debug] Proxy map: {}
[ComCarCoff] stephen-colbert-cut-up-and-bloody-but-looking-good: Downloading webpage
ERROR: Unable to extract full data json; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 665, in extract_info
    ie_result = ie.extract(url)
  File "./youtube-dl/youtube_dl/extractor/common.py", line 291, in extract
    return self._real_extract(url)
  File "./youtube-dl/youtube_dl/extractor/comcarcoff.py", line 36, in _real_extract
    webpage, 'full data json'))
  File "./youtube-dl/youtube_dl/extractor/common.py", line 586, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract full data json; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

(the example link above is http://comediansincarsgettingcoffee.com/stephen-colbert-cut-up-and-bloody-but-looking-good)

To fix the issue, I created a PR, #7942. Really, I just tweaked the regex for finding the JSON object; its structure seems to be almost exactly the same as before.

Thanks, and I hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.