Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Disabling 'ScaledBorderAndShadow' in ass files (especially crunchyroll) #8207

Closed
Confruggy opened this issue Jan 11, 2016 · 6 comments
Labels

Comments

@Confruggy
Copy link

@Confruggy Confruggy commented Jan 11, 2016

I downloaded some Crunchyroll videos and noticed that the border of the fonts are ugly big. After checking the ass files i found a parameter calling 'ScaledBorderAndShadow' which is normally set to 'yes' but after setting it to 'no' the fonts are looking how they should like.

Example:
This is how it looks like

After setting 'ScaledBorderAndShadow' to 'no'

So an option would be that the parameter is set automatically to 'no' while writing the sub files.

@vxbinaca
Copy link
Contributor

@vxbinaca vxbinaca commented Jan 12, 2016

Perhaps tag this item with "feature request" will speed a solution?

@jaimeMF jaimeMF added the subtitles label Jan 12, 2016
@misakitchi
Copy link

@misakitchi misakitchi commented Nov 19, 2016

I want this option too! :)

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Nov 19, 2016

Related: #9028
Which is better, change ScaledBorderAndShadow: yes to ScaledBorderAndShadow: no or just remove ScaledBorderAndShadow: yes?

@misakitchi
Copy link

@misakitchi misakitchi commented Nov 19, 2016

Have an option to say "yes" or "no"
Some people like it with and some without...
But by default i prefere without: so "ScaledBorderAndShadow: no"

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Nov 19, 2016

Closing since #9028 merged.

More details:
As libass defaults this value to yes, youtube-dl has to set it to false manually to override. If players want to override it again, they can call ass_set_style_overrides, which MPlayer/mpv supports.

@yan12125 yan12125 closed this Nov 19, 2016
@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Feb 1, 2017

FYI: I've revert previous changes. See @lachs0r's comments at #9028 for statements that persuaded me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.