Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
youtube-dl is prioritizing youtube embeds in comment threads over first party jwplayer video #8570
Comments
alexbobp
changed the title
|
Similar to #5587. |
|
@yan12125 I don't agree with treating this as a duplicate. The issue you linked talks about one specific approach, but it's been 9 months that the ticket has been ignored with no progress. You could at least comment on some of the other approaches I suggested. My favorite would be to prioritize jwplayer over 3rd party embeds, and surely that's a much easier change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Normally youtube-dl works great on rooster teeth pages.
For example:
works normally and downloads season 3 chapter 11, using the generic extractor.
downloads season 2, chapter 7, using the youtube extractor! What is happening? Someone linked that episode via youtube in the comments thread, the rooster teeth cms turns it into an embed, and for some reason youtube-dl is picking that up instead of the main page video. I also tried with --force-generic-extractor and it had no impact, the wrong video is still downloaded and seemingly the youtube extractor is still used.
I am not sure the best solution. Detecting and excluding comment sections... prioritizing content higher up on the page... prioritizing jwplayer embeds over remote site embeds... detecting and downloading all videos even if they don't use the same extractor... all seem like options to consider. My personal preference would be to consider a jwplayer embed to be more likely to be first class content than a youtube embed.