Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
progresshook on fragment.py: Inconsistent behavior on total_bytes #8711
Comments
None of these fields are guaranteed to be present at all. |
|
It may be None for unknown values, as explained so in docs, or the documentation itself is not consistent with the behavior. |
|
It may be present or may not. If present it may contain a value or |
In the documentation of progress_hooks, it's said that that if total_bytes is unknown, the value would be None:
However this is not the case for fragment.py, where the key simply doesn't exist:
This has caused downstream issues such as KeyError: 'total_bytes'