Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
CC/TDS extractor sets file date incorrectly #894
Comments
|
comedycentral literally tells us the file is from that date, so we set it as mtime (that's quite helpful if the date is correct). By the way, Fixed in git, will be in the next version. Thank you for reporting. |
|
So, just to confirm, the fix was "if we are sent a date at end-of-transfer, ignore it if it appears insane? |
|
Nevermind; I can actually read that much python. Thanks. :-) |
|
We're getting the date at the beginning of the transfer, and we're simply ignoring it (i.e. pretending no date was given) if it's the epoch (i.e. January 1st 1970 00:00:00). |
When downloading the Daily Show, I find that the file dates are set to what appears to be 0L at the end of the download, a unixtime which is interpreted as 23:59:59 31 Dec 1969 -- the date part being what ls and Midnight Commander agree is the mtime of the file.
I'm inferring that it's being set purposefully since the .mp4.part file into which the show is downloaded carries a current-date mtime, during the download. The only switch I'm specifying is "-c".
I'm not sure what would be the best date to which to set the file, if there's a good reason to set it to something other than the download time, but 1969 is pretty clearly not that best date. ;-)