Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC/TDS extractor sets file date incorrectly #894

Closed
Baylink-gh opened this issue Jun 19, 2013 · 4 comments
Closed

CC/TDS extractor sets file date incorrectly #894

Baylink-gh opened this issue Jun 19, 2013 · 4 comments

Comments

@Baylink-gh
Copy link

@Baylink-gh Baylink-gh commented Jun 19, 2013

When downloading the Daily Show, I find that the file dates are set to what appears to be 0L at the end of the download, a unixtime which is interpreted as 23:59:59 31 Dec 1969 -- the date part being what ls and Midnight Commander agree is the mtime of the file.

I'm inferring that it's being set purposefully since the .mp4.part file into which the show is downloaded carries a current-date mtime, during the download. The only switch I'm specifying is "-c".

I'm not sure what would be the best date to which to set the file, if there's a good reason to set it to something other than the download time, but 1969 is pretty clearly not that best date. ;-)

@phihag phihag closed this in bb47437 Jun 19, 2013
@phihag
Copy link
Contributor

@phihag phihag commented Jun 19, 2013

comedycentral literally tells us the file is from that date, so we set it as mtime (that's quite helpful if the date is correct). By the way, -c is the default now.

Fixed in git, will be in the next version. Thank you for reporting.

@Baylink-gh
Copy link
Author

@Baylink-gh Baylink-gh commented Jul 13, 2013

So, just to confirm, the fix was "if we are sent a date at end-of-transfer, ignore it if it appears insane?

@Baylink-gh
Copy link
Author

@Baylink-gh Baylink-gh commented Jul 13, 2013

Nevermind; I can actually read that much python. Thanks. :-)

@phihag
Copy link
Contributor

@phihag phihag commented Jul 13, 2013

We're getting the date at the beginning of the transfer, and we're simply ignoring it (i.e. pretending no date was given) if it's the epoch (i.e. January 1st 1970 00:00:00).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.