Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Download fails when using --write-srt without subtitles #901
Comments
|
Ok, the problem is that we didn't set a default language for automatic capitons.
|
|
Regarding the first question: Yes definitely, I think the best method would be to have another command-line option for the automatic subtitles if people really want them, i.e. "--write-automatic-srt", because let's be honest, most of the time they are less than inadequate. Regarding the second question, no, I don't really, since the version of youtube-dl I had been using until now didn't do that either. In my opinion a simple warning output would be ideal since it certainly isn't a "fatal error" that prevents the actual file (the video) from being downloaded, a bit of the metadata will simply be missing. The "--ignore-errors" option should be used to actively ignore failed video downloads in my opinion. Thank you, and absolutely no problem. |
… found (related #901) For example when downloading a playlist some videos may not have subtitles but the download shouldn't stop.
|
You are right, now it just reports warnings. |
|
@cryzed BTW |
|
Thanks for the heads up, Jaime. I haven't been really paying attention to changing command-line arguments, I've been using youtube-dl in combination with batch-youtube-dl.py, it basically allows me to just create a batch-file.txt with the URLs to download (e.g. a playlist) and the appropriate command-line arguments, seems like I need to update some of those. |
|
@cryzed That script is only useful if you have multiple batch files. In all other instances, simply calling
should suffice. |
|
That is exactly what I wrote it for actually -- being able to use multiple batch-files. I have the following folder structure:
I execute the batch-youtube-dl.py script in the YouTube root folder and all my playlists will be updated. I know that I can use youtube-dl like that, thank you though. |
The video download fails entirely when there are no subtitles to be downloaded while using the "--write-srt" command-line option. Usually I use the following options by default to retrieve all the video's metadata if available:
This new behavior makes this impossible. I get the following error message: