(2016.03.27) Infinite redirection loop

[shaicoleman]

After reaching the a redirect limit (e.g. 10 redirects), it should throw an error, instead of continuing forever in a loop.

$ youtube-dl 'http://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/a-tribute-to-jenny-slate-on-talk-shows'

[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video.php?v=http://heytinafey.tumblr: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Extracting information
[redirect] Following redirect to https://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/&_fb_noscript=1
[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video.php?v=http://heytinafey.tumblr: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Extracting information
[redirect] Following redirect to https://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/&_fb_noscript=1
[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video.php?v=http://heytinafey.tumblr: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Extracting information
[redirect] Following redirect to https://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/&_fb_noscript=1
[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video.php?v=http://heytinafey.tumblr: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Extracting information
[redirect] Following redirect to https://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/&_fb_noscript=1
[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video.php?v=http://heytinafey.tumblr: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Extracting information
[redirect] Following redirect to https://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/&_fb_noscript=1
[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header
WARNING: Falling back on generic information extractor.
[generic] video.php?v=http://heytinafey.tumblr: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Extracting information
[redirect] Following redirect to https://www.facebook.com/video/video.php?v=http://heytinafey.tumblr.com/post/140426183278/&_fb_noscript=1
[Tumblr] 140426183278: Downloading webpage
[generic] video.php?v=http://heytinafey.tumblr: Requesting header

And it continues looping forever

[w1lford]

Does this only occur in the Facebook extractor?

[shaicoleman]

So far, this is the only URL type (tumblr within Facebook) that I know of that reproduces this issue. I'm guessing the issue is not specific to Facebook, but every time it is forwarded to a different extractor, and each extractor has its own counts. What's missing is a counter that checks how many times it gets redirected to the different extractors.