Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
FFmpeg error while embedding subtitles in lynda.com videos #9063
Comments
|
There seems to be some problem in the downloaded file, For developers: changing in the commandline |
|
This problem could potentially be related to #8855. @jaimeMF I just tested with a dozen other lynda.com courses. All but one latest course (published on Mar 24, 2016) are giving the same error; examining the downloaded |
xty
changed the title
|
Yes, it seems to be the same problem. |
[ffmpeg] Fix embedding subtitles (#9063)
This reverts commit ccff2c4. Fixes #10081. The new approach breaks embedding subtitles into video-only or audio-only files. FFMpeg provides a trick: add '?' after the argument of '-map' so that a missing stream is ignored. For example: opts = [ '-map', '0:v?', '-c:v', 'copy', '-map', '0:a?', '-c:a', 'copy', # other options... ] Unfortunately, such a format is not implemented in avconv, either. I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the best solution. However, the example mentioned in #9063 no longer serves problematic files, so I can't test it. I'll reopen #9063 and wait for another example so that I can test '-ignore_unknown'.
|
The latest change in subtitle embedding breaks in some cases (#10081). The example above no longer serves problematic files. Do you have other examples? @xiatianyu @reyyed |
|
Hi, I'm sorry that I did not consider the cases where subtitles are embedded into video or audio only files. The example which I relied on previously was Jekyll for Web Designers. I've tried downloading it with the latest build of youtube-dl and did not encounter any ffmpeg error. It's possible that there have been efforts by lynda to fix the files since both @xiatianyu and my examples no longer give problematic files. |
|
OK I'm closing this now until someone else finds another example. |
Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2016.04.01.Before submitting an issue make sure you have:
What is the purpose of your issue?
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Description of your issue, suggested solution and other information
As suggested in the title, the problem occurs when FFmpeg attempts to merge the downloaded
.srtfile into the.mp4file. Consequently, the program halted, the merge failed and the downloads of all other videos in the sequence did not proceed. It is noteworthy that the only video and subtitles files that did get downloaded are complete, uncorrupted and play together nicely.This problem was previously identified by @horusra in #8434 after it was closed:
Considering the aforementioned thread was closed and left unattended, and it would be ill-advised to dump various issues into one ticket, I am filing a separate issue here to make the problem resurface.
Please note that the problem is also reproducible without the use of the
--username,--password(for individual login) or--cookies(for organizational login) options, as the first couple of videos in each lynda.com course are accessible even when the viewer is not logged in. That being said, I am more than willing to provide my credentials should they be required for further testing.