Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpegMetadataPP does not process `creator` field from info extractor #9076

Closed
blahgeek opened this issue Apr 4, 2016 · 1 comment
Closed

FFmpegMetadataPP does not process `creator` field from info extractor #9076

blahgeek opened this issue Apr 4, 2016 · 1 comment

Comments

@blahgeek
Copy link
Contributor

@blahgeek blahgeek commented Apr 4, 2016

  • I've verified and I assure that I'm running youtube-dl 2016.04.01

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)

In FFmpegMetadataPP:

        if info.get('artist') is not None:
            metadata['artist'] = info['artist']

Only artist field is used.

But in the documentation of InfoExtractor:

creator:        The main artist who created the video.

There's no artist field from any info extractor.

Shouldn't it be something like

        if info.get('creator') is not None:
            metadata['artist'] = info['creator']

?

Thanks!

@blahgeek
Copy link
Contributor Author

@blahgeek blahgeek commented Apr 4, 2016

Also, FFmpegMetadataPP uses album field as metadata, which is also not mentioned in the documentation of InfoExtractor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.