Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[youtube] hangs with HLS format #9106
Comments
|
For developers: This video has DASH formats and youtube-dl should be able to process them. |
|
@remitamine Simply removing the following check works for this video: diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py
index ec6625e..6794b07 100644
--- a/youtube_dl/extractor/common.py
+++ b/youtube_dl/extractor/common.py
@@ -1401,9 +1401,6 @@ class InfoExtractor(object):
compat_etree_fromstring(mpd.encode('utf-8')), mpd_id, mpd_base_url, formats_dict=formats_dict)
def _parse_mpd_formats(self, mpd_doc, mpd_id=None, mpd_base_url='', formats_dict={}):
- if mpd_doc.get('type') == 'dynamic':
- return []
-
namespace = self._search_regex(r'(?i)^{([^}]+)?}MPD$', mpd_doc.tag, 'namespace', default=None)
def _add_ns(path):Is this check really necessary? |
|
there was a previous discussion with @dstftw about this(i don't remember on what commit). |
|
This is to skip livestreams since we are unable to process real livestreams with audio/video separated. This video however does not look like livestream however manifest tells it is. |
|
I see the rationale. I guess it's because YouTube is still in progress of merging live stream segments into a single file for each format. Maybe we can detect whether it's really a live stream or not, and enable DASH formats for those just finished their live events? |
|
YouTube has done post-processing for Gjv9LrRPo0Q. Superseded by #10787. |
What is the purpose of your issue?
When downloading a youtube video with HLS, it just hangs