Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "--match-description" option. #9149

Closed
sebma opened this issue Apr 10, 2016 · 7 comments
Closed

Add a "--match-description" option. #9149

sebma opened this issue Apr 10, 2016 · 7 comments
Labels

Comments

@sebma
Copy link

@sebma sebma commented Apr 10, 2016

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.06. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2016.04.06

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.04.06
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):


Description of your issue, suggested solution and other information

Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.

If work on your issue required an account credentials please provide them or explain how one can obtain them.

Hi, can you add a --match-description option that searches for a string amongst the description of a video ?

Thanks.

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Apr 11, 2016

--match-filter should be enough. Post more details if you have problems.

@yan12125 yan12125 closed this Apr 11, 2016
@sebma
Copy link
Author

@sebma sebma commented Apr 11, 2016

Hi, I agree but then what would be the equivalent of:

--match-description myString

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Apr 11, 2016

Could you give a concrete URL and your expectations?

@sebma
Copy link
Author

@sebma sebma commented Apr 11, 2016

Sure:

youtube-dl --get-id --match-description "karambiri" https://www.youtube.com/channel/UCFyNsaSkagjA-z-o6qf10nA/videos

I expect the video ID's of that containing the string karambiri in their description.

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Apr 11, 2016

containing the string karambiri in their description.

Currently only exact matching is implemented.

@yan12125 yan12125 reopened this Apr 11, 2016
@yan12125 yan12125 added the request label Apr 11, 2016
@prestonhansen
Copy link

@prestonhansen prestonhansen commented Apr 13, 2016

Would something like (similar to how match_filter is made)...

"""in utils.py"""
def match_desc_str(filter_str,dct):
    return all(dct.get('description').find(item) for item in filter_str.split('&'))

def match_desc_func(filter_str):
    def _match_desc(info_dict):
        if match_desc_str(filter_str,info_dict):
            return None
        else:
            return "error message goes here"
    return _match_desc

...and in YoutubeDL.py...

"""in _match_entry"""
    #...
    #...
    #...
    #...
    if not incomplete:
        match_filter = self.params.get('match_filter')
        if match_filter is not None:
            ret = match_filter(info_dict)
            if ret is not None:
                return ret
        match_desc = self.params.get('match_desc')
        if match_filter is not None:
            ret = match_desc(info_dict)
            if ret is not None:
                return ret

    return None

...with the corresponding option added in options.py added work?

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Feb 25, 2017

Thanks phansen01 for the idea. A guideline in youtube-dl is don't add new options if a new feature can be implemented by improving existing options. As a result, this issue is actually the same as #9092. Please move there for further discussions.

@yan12125 yan12125 closed this Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.