Unused field from info_dict in FileDownloader

[jaimeMF]

I was reading the code in FileDownloader.py and I see this piece of code (source):

try:
    if count == 0 and 'urlhandle' in info_dict:
        data = info_dict['urlhandle']
    data = compat_urllib_request.urlopen(request)
    break
except (compat_urllib_error.HTTPError, ) as err:
    ...

If I'm not wrong, the info_dict['urlhandle'] is being overwritten always, so it's never used. Is that the intended behaviour, or it's just that I have misundestoond something?

[phihag]

That looks like a mistake. Feel free to remove after checking that the code that uses urlhandle at all still works.

[jaimeMF]

If I understand it well (I haven't dive deeply in the downloader) the urlhandle should be used instead of compat_urllib_request.urlopen(request), so my solution would be to do:

 if count == 0 and 'urlhandle' in info_dict:
    data = info_dict['urlhandle']
else:
    data = compat_urllib_request.urlopen(request)

I would like to test it, but only Blip.tv uses this field and only with some videos, and I can't find any of them.
Also this is the only part on the code where the urlhandle is used, have I missed something?

[jaimeMF]

Fixed in 1538eff, thanks.