Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Retry request after socket-timeout #9483

Closed
spookyahell opened this issue May 13, 2016 · 3 comments
Closed

Feature request: Retry request after socket-timeout #9483

spookyahell opened this issue May 13, 2016 · 3 comments

Comments

@spookyahell
Copy link

@spookyahell spookyahell commented May 13, 2016

  • I've verified and I assure that I'm running youtube-dl 2016.05.10

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

Issue is: I use a local proxy for requests that sometimes freezes and won't respond. Usually I have to execute a whole command again, even if it's already almost done. The option "--socket-timeout" only automatically quits the command, it doesn't retry the current request.

An option like "--socket-timeout-retry SECONDS" would be nice to have. It would need to do what socket-timout does and then continue where it left of.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 13, 2016

Isn't --retries enough? There is no such thing as "command almost done". In general extraction process is extractor specific and particular extractor may want to have own retry strategy or do not have such.

@spookyahell
Copy link
Author

@spookyahell spookyahell commented May 13, 2016

When does a retry trigger? Does ít trigger when nothing happens for a certain amount of time? I kind of have the feeling that the extractor won't retry what it needs to finish. I meant sometimes it's only few requests to end but a lot if you restart the whole extraction process. Almost done: Nearly ready to create and execute ffmpeg command.

@ssokolow
Copy link

@ssokolow ssokolow commented May 22, 2017

Is it possible that this is another manifestation of one of the "socket timeouts don't trigger retry" bugs described in issues #8625 and #4240?

@dstftw dstftw closed this in a3c3a1e Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.