Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo: ignore album in video URL #9603

Closed
ghost opened this issue May 26, 2016 · 2 comments
Closed

Vimeo: ignore album in video URL #9603

ghost opened this issue May 26, 2016 · 2 comments

Comments

@ghost
Copy link

@ghost ghost commented May 26, 2016

Hi.

https://github.com/rg3/youtube-dl/blob/master/youtube_dl/extractor/vimeo.py#L577 here some little bit wrong logic.

We have protected album, right?
But it not necessary we have protected video in protected album. :)

URL: https://vimeo.com/album/[albumId]/video/[videoId].

albumId is some of protected albums, videoId is public. We should ignore album b/c we already know video ID: https://vimeo.com/[videoId].

So album should be ignored in video URL.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented May 26, 2016

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Jul 27, 2016

Closing as no response for a long time.

@yan12125 yan12125 closed this Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.