Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iqiyi: test regression #9912

Closed
4 of 8 tasks
anisse opened this issue Jun 26, 2016 · 7 comments
Closed
4 of 8 tasks

Iqiyi: test regression #9912

anisse opened this issue Jun 26, 2016 · 7 comments

Comments

@anisse
Copy link
Contributor

anisse commented Jun 26, 2016

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.06.25. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2016.06.25

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

test_Iqiyi_2 test had a recently introduced regression:
https://travis-ci.org/anisse/youtube-dl/builds/140328781

This is the new test infrastructure discussed in #8496 that detected it (it has an auto-merge to trigger builds).

@anisse
Copy link
Contributor Author

anisse commented Jun 26, 2016

ping @yan12125

@yan12125
Copy link
Collaborator

test_Iqiyi_2 is a VIP-only video and I haven't fixed it yet.

@anisse
Copy link
Contributor Author

anisse commented Jun 26, 2016

Ah, so it's in fact failing (it's downloading the ad as said in the other bug ?)

@yan12125
Copy link
Collaborator

Yep it's falling. Unlike non-VIP videos, this one now returns nothing.

@anisse
Copy link
Contributor Author

anisse commented Jul 3, 2016

There's another regression, probably introduced by 2644e91. See https://travis-ci.org/anisse/youtube-dl/jobs/142021660

Is it another VIP video?

@yan12125
Copy link
Collaborator

yan12125 commented Jul 4, 2016

Apparently Iqiyi serves different files to Travis CI and my machine.

@yan12125
Copy link
Collaborator

yan12125 commented Jul 4, 2016

Fixed by 3a212ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants