Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize combining accents in sanitize_filename() #9947

Open
sebma opened this issue Jun 29, 2016 · 3 comments
Open

Recognize combining accents in sanitize_filename() #9947

sebma opened this issue Jun 29, 2016 · 3 comments
Labels

Comments

@sebma
Copy link

@sebma sebma commented Jun 29, 2016

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.06.27. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2016.06.27

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.06.27
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):


Description of your issue, suggested solution and other information

Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.


Hi,

There are extra underscores in the filename in restrict mode when there should not be :

$ youtube-dl --version
2016.06.27
$ youtube-dl -f 18 --get-filename --restrict-filename hYDQZleciXE
Joseph_Prince_-_La_Gra_ce_est_Supe_rieure_a_La_Loi_-_FR__18__hYDQZleciXE.mp4

The command line youtube-dl -f 18 --get-filename --restrict-filename hYDQZleciXE should return:

Joseph_Prince_-_La_Grace_est_Superieure_a_La_Loi_-_FR__18__hYDQZleciXE.mp4

Can you have a look ?

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Jul 2, 2016

The letter â is in fact a plain alphabet letter a with "combining circumflex accent". Such combinations are not supported yet.

Reference: http://www.utf8-chartable.de/unicode-utf8-table.pl?start=768&number=128

@yan12125 yan12125 added the request label Jul 2, 2016
@yan12125 yan12125 changed the title There are extra underscores in the filename in restrict mode when there should not be. Support combining accents Jul 2, 2016
@yan12125 yan12125 changed the title Support combining accents Recognize combining accents in sanitize_filename() Jul 2, 2016
@sebma
Copy link
Author

@sebma sebma commented Aug 8, 2017

Hi, why does the "é" appears like "_" instead of "e" ?

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Aug 8, 2017

é is not turned into a underscore. Instead, é is a combination of e and accent symbol, and the accent symbol is turned into _, so the result is e_.

That's indeed a problem and seems it's hard to fix. Apparently an algorithm to identify accent symbols is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.