[Freesound] extended and fix "title" extraction closes #11602 #11608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jan 7, 2017
| description = self._html_search_regex( | ||
| r'<div id="sound_description">(.*?)</div>', webpage, 'description', | ||
| fatal=False, flags=re.DOTALL) | ||
|
|
||
| duration = float_or_none(get_element_by_class('duration', webpage)) | ||
| if duration: | ||
| duration = duration / 1000 |
There was a problem hiding this comment.
scale passed to float_or_none instead.
| filesize = float_or_none(self._search_regex( | ||
| r'Filesize</dt><dd>(\d+.\d+).*</dd>', sound_info, 'file size (approx)', fatal=False)) | ||
| if filesize: | ||
| filesize = filesize * 1048576 |
There was a problem hiding this comment.
parse_filesize() shows a bit smaller size (MB * 1000 instead of MB * 1024), but I don't think it's a big of an issue because it shows filesize approximately anyway.
There was a problem hiding this comment.
MB stands for mega 10^6, not 2^20.
Also this file size has nothing to do with resulting mp3 file. It's probably for original wav.
There was a problem hiding this comment.
ah... 50.5 MB equals 48.7-something MiB you're correct. So it's fine.
|
|
||
| download_count = int_or_none(self._html_search_regex( | ||
| r'Downloaded.*>(\d+)<', webpage, 'downloaded', fatal=False)) | ||
| audio_url = self._og_search_property('audio', webpage, 'song url') |
There was a problem hiding this comment.
This should be extracted in the first place.
| formats = [{ | ||
| 'url': audio_url, | ||
| 'id': music_id, | ||
| 'format_id': self._og_search_property('audio:type', webpage, 'audio format'), |
| return { | ||
| 'id': music_id, | ||
| 'title': title, | ||
| 'url': self._og_search_property('audio', webpage, 'music url'), | ||
| 'title': self._og_search_property('audio:title', webpage, 'song title'), |
There was a problem hiding this comment.
This should be extracted in the first place.
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Extractor now fills more data and works correctly.