Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8] Ignore W504 (line break after binary operator) #20863

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@jwilk
Copy link
Contributor

commented Apr 27, 2019

Both W504 (line break after binary operator) and W503 (line break before binary operator) were implicitly enabled, even though conceptually they are mutually exclusive.

W504 had over 100 hits, while W503 had none, so let's disable the former.

[flake8] Ignore W504 (line break after binary operator)
Both W504 (line break after binary operator) and W503 (line break before binary
operator) were implicitly enabled, even though conceptually they are mutually
exclusive.

W504 had over 100 hits, while W503 had none, so let's disable the former.
@dstftw

This comment has been minimized.

Copy link
Collaborator

commented May 10, 2019

Looks like W504 is now PEP 8 recommended style, so I guess it's better to fix the code and not disable it.

@dstftw dstftw closed this in 3089bc7 May 10, 2019

@jwilk jwilk deleted the jwilk-forks:flake8 branch May 10, 2019

paolodedios added a commit to paolodedios/youtube-dl that referenced this pull request May 13, 2019

Merge branch 'master' of github.com:rg3/youtube-dl
* 'master' of github.com:rg3/youtube-dl:
  [tele5] Improve video id extraction
  [tele5] Relax _VALID_URL (closes ytdl-org#21020, closes ytdl-org#21063)
  [svtplay] Update API URL (closes ytdl-org#21075)
  [yahoo:gyao] add X-User-Agent header to dam proxy requests(closes ytdl-org#21071)
  release 2019.05.11
  [ChangeLog] Actualize [ci skip]
  [extractor/common] Fix typo
  Fix W504 and disable W503 (closes ytdl-org#20863)
  [tvnow] Fix W605
  [commonmistakes] Fix E117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.