Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coding conventions #21939

Merged
merged 3 commits into from Aug 1, 2019

Conversation

@kylepw
Copy link
Contributor

commented Jul 30, 2019

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Improvement

Description of your pull request and other information

I added some coding conventions based on maintainers' reoccurring comments on pull requests. Issues included: inline values, collapsing fallbacks, and trailing parentheses. My hope is that these additions will save contributor's and maintainer's time.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved

@kylepw kylepw force-pushed the kylepw:guidelines branch from 2a2882b to 4a92da3 Jul 31, 2019

@kylepw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@dstftw Requested changes made. Let me know if this works.

@kylepw kylepw force-pushed the kylepw:guidelines branch from 4a92da3 to 748ef7d Jul 31, 2019

CONTRIBUTING.md Outdated Show resolved Hide resolved

@kylepw kylepw force-pushed the kylepw:guidelines branch from 3267261 to 9ecf3ee Aug 1, 2019

@dstftw dstftw merged commit 07f3a05 into ytdl-org:master Aug 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pull bot pushed a commit to 3Golds/youtube-dl that referenced this pull request Aug 1, 2019

@dstftw dstftw removed the pending-fixes label Aug 1, 2019

@kylepw kylepw deleted the kylepw:guidelines branch Aug 2, 2019

Lamieur added a commit to Lamieur/youtube-dl that referenced this pull request Aug 3, 2019

Lamieur added a commit to Lamieur/youtube-dl that referenced this pull request Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.