Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vimeo] Adds a specific hint for which param to use when a video is password protected #22683

Closed
wants to merge 1 commit into from

Conversation

1RedOne
Copy link

@1RedOne 1RedOne commented Oct 11, 2019

#22094 Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

With Vimeo vids, we see lots of people raising issues (like this one, #15980 ) when they are trying to provide a -Password param, which is the wrong choice for the Vimeo domain for password protected videos. If a user tries to download a password protected video and provides no password, there is a UI hint in the error message for that...but not if they use the patently wrong param like this.

This patch adds a specific hint on the Vimeo wrong username/password scenario to mitigate this in the future, like #15980

With Vimeo vids, we see lots of people raising issues trying to provide a -Password param, which is the wrong choice for the Vimeo domain for password protected videos.

This patch adds a specific hint on the Vimeo wrong username/password scenario to mitigate this in the future, like #15980
@dstftw
Copy link
Collaborator

dstftw commented Oct 11, 2019

If user downloads a password protected video or an album without providing a password he will be explicitly prompted about that. No need to create a mess in unrelated places.

@dstftw dstftw closed this Oct 11, 2019
@1RedOne
Copy link
Author

1RedOne commented Oct 11, 2019

Check out the related issue, people have mistakenly thought that -Password was the way to go (myself included). In one of those threads, you yourself had to direct people on the right param to use.

Why not display a hint to the user in such a case?

@dstftw
Copy link
Collaborator

dstftw commented Oct 11, 2019

Why do you even think writing this hint in another place will make any difference? If one does not bother reading output he won't read it from here either.
mistakenly thought is a really bad excuse. What if one'd mistakenly thought that --username is the way to go for custom user agent? Or similarly --password for --ap-password? Or more terminal scenarios? Make another additions to hint for these cases? What about another extractors? Add these hints to all other extractors with authentication? No, never happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants